Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate and deactivate buttons are in wrong state #49

Open
anthonykim1 opened this issue Dec 3, 2024 · 3 comments
Open

Activate and deactivate buttons are in wrong state #49

anthonykim1 opened this issue Dec 3, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@anthonykim1
Copy link

anthonykim1 commented Dec 3, 2024

Testing #24503

First case, the deactivate button persist and does not switch to activate button even after successfully deactivating:
Image

Second case,
Say I have two separate zsh instances in VS Code terminal:

  1. The very first terminal, I click deactivate and leads to successful deactivation, the UI shows activate button as expected.
  2. The second zsh instance where environment is activate, it does not show deactivate button but rather activate button. I believe this is wrongly cached? See the video.
Screen.Recording.2024-12-03.at.9.21.05.AM.mov
@anthonykim1 anthonykim1 changed the title Activate button persists when deactivate button should show up Activate and deactivate buttons are in wrong state Dec 3, 2024
@anthonykim1 anthonykim1 added the bug Issue identified by VS Code Team member as probable bug label Dec 3, 2024
@karthiknadig
Copy link
Member

@anthonykim1 How was the second terminal activated? If it was not through the extension then it does not know.

@anthonykim1
Copy link
Author

I see, when you say through extension, you mean environment manager extension, correct?

@karthiknadig
Copy link
Member

Yes, the env manager UI has inline context item to create terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants