Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.12-dev to tests actions #326

Closed
luabud opened this issue Sep 22, 2023 · 3 comments · Fixed by #330
Closed

Add Python 3.12-dev to tests actions #326

luabud opened this issue Sep 22, 2023 · 3 comments · Fixed by #330
Assignees
@pheonix-18
Labels
debt Technical debt or repo cleanup good first issue Good for newcomers needs PR

Comments

@luabud
Copy link
Member

luabud commented Sep 22, 2023

We should add Python 3.12-dev here and see if all tests pass: https://github.com/microsoft/vscode-isort/blob/main/.github/workflows/pr-check.yml
@luabud luabud added good first issue Good for newcomers debt Technical debt or repo cleanup needs PR ghc-osd labels Sep 22, 2023
@pheonix-18
Copy link
Contributor

Can I take this issue @luabud

@eleanorjboyd
Copy link
Member

eleanorjboyd commented Sep 22, 2023 •
edited by anthonykim1
Loading

@karthiknadig, this addition failed on the python repo- do we anticipate it will work on this repo?
--Edit: Yes

pheonix-18 pushed a commit to pheonix-18/vscode-isort that referenced this issue Sep 22, 2023
@Spunati9
Fix microsoft#326: Added Python 3.12 to tests actions
7d8707c
pheonix-18 added a commit to pheonix-18/vscode-isort that referenced this issue Sep 22, 2023
@pheonix-18
Fixes microsoft#326: Add Python 3.12-dev to tests actions
3c56e62
@pheonix-18
Copy link
Contributor

pheonix-18 commented Sep 22, 2023 •
edited
Loading

Made PR: #330

@eleanorjboyd eleanorjboyd mentioned this issue Sep 22, 2023
Merged
pheonix-18 added a commit to pheonix-18/vscode-isort that referenced this issue Sep 22, 2023
@pheonix-18
Fixes microsoft#326: Add Python 3.12-dev to tests actions
7752594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pheonix-18 pheonix-18

Labels
debt Technical debt or repo cleanup good first issue Good for newcomers needs PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Python 3.12-dev to tests actions pheonix-18/vscode-isort
3 participants
@eleanorjboyd @luabud @pheonix-18