[imgui] Add sfml feature. #7421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NancyLi1013
added
the
info:internal
|
ImGui-SFML maintainer here. That doesn't feel right to me, and I feel like ImGui-SFML needs to have an option to build without ImGui's source code. ImGui's vcpkg script should not depend on ImGui-SFML in any way. Maybe you can suggest how ImGui-SFML can allow fo more flexibility to allow you to get ImGui in some other way? What does vcpkg provide? |
|
@eliasdaler , thanks for your feedback. Sorry for the late reply. I noticed that you and @tntxtnt have talked about this issue in PR #7429. I agree with you that we should add ImGui-SFML as a single port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to imgui-sfml needs to build with imgui source code, it cannot be as a single port to be built.
So I add sfml to imgui as its feature.
Related issue #7333.