Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rocksdb] update to v8.3.2, add/rework features #29093

Merged
merged 33 commits into from
Jul 7, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
35abbb1
add more options and remove unused CMake variables
yurybura Jan 21, 2023
844f015
add version
yurybura Jan 21, 2023
f91dd1c
[rocksdb] fix liburing option
yurybura Jan 22, 2023
1df7d02
update version
yurybura Jan 22, 2023
182845e
[rocksdb] disable debug runtime for Release configuration (Windows only)
yurybura Jan 22, 2023
5bfc94c
update version
yurybura Jan 22, 2023
975031c
[rocksdb] remove processor-specific features
yurybura Mar 13, 2023
6e940d6
[rocksdb] update v7.10.2
yurybura Mar 13, 2023
4a147d0
add version
yurybura Mar 13, 2023
5546099
[rocksdb] update to v8.0.0
yurybura Mar 19, 2023
0fa8ece
add version
yurybura Mar 19, 2023
c6f55fa
Merge branch 'master' of https://github.com/microsoft/vcpkg into rock…
yurybura Mar 23, 2023
2db63bb
add version
yurybura Mar 23, 2023
ae3b4dc
Merge branch 'master' of https://github.com/microsoft/vcpkg into rock…
yurybura Apr 3, 2023
f13e4fd
modify version
yurybura Apr 5, 2023
ccc8284
add version
yurybura Apr 5, 2023
5ee0648
Merge branch 'master' of https://github.com/microsoft/vcpkg into rock…
yurybura Apr 14, 2023
bf2241d
[rocksdb] update to v8.3.2, build shared library, update ci.basline.txt
yurybura Jun 24, 2023
dc29ca6
update version
yurybura Jun 24, 2023
b144e40
Merge branch 'master' into rocksdb-features
yurybura Jun 24, 2023
7941a9f
[rocksdb] PORTABLE option has been modified in v8.3, it should be equ…
yurybura Jun 25, 2023
6720e8c
clean up ci.baseline.txt
yurybura Jun 25, 2023
77225e2
=update version
yurybura Jun 25, 2023
6bc6ad0
revert "clean up ci.baseline.txt"
yurybura Jun 26, 2023
903b003
remove unnecessary lines
yurybura Jun 26, 2023
97b32a5
update version
yurybura Jun 26, 2023
5e6130e
update ci.baseline.txt
yurybura Jun 27, 2023
a090a85
update version
yurybura Jun 27, 2023
4c9bd82
Merge branch 'master' of https://github.com/microsoft/vcpkg into rock…
yurybura Jun 29, 2023
d650d33
Merge branch 'microsoft:master' into rocksdb-features
yurybura Jul 2, 2023
e57df3a
[rocksdb] remove JeMalloc
yurybura Jul 7, 2023
9b3de77
update version
yurybura Jul 7, 2023
72d6bc7
Merge branch 'microsoft:master' into rocksdb-features
yurybura Jul 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ports/rocksdb/0004-fix-dependency-in-config.patch
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
cmake/RocksDBConfig.cmake.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

yurybura marked this conversation as resolved.
Show resolved Hide resolved
diff --git a/cmake/RocksDBConfig.cmake.in b/cmake/RocksDBConfig.cmake.in
index 0bd14be11..f9f6aa878 100644
index 0bd14be11..ad07f018a 100644
--- a/cmake/RocksDBConfig.cmake.in
+++ b/cmake/RocksDBConfig.cmake.in
@@ -37,7 +37,7 @@ if(@WITH_LZ4@)
@@ -33,11 +33,11 @@ if(@WITH_BZ2@)
endif()

if(@WITH_LZ4@)
- find_dependency(lz4)
+ find_dependency(lz4 CONFIG)
yurybura marked this conversation as resolved.
Show resolved Hide resolved
endif()

if(@WITH_ZSTD@)
Expand Down
24 changes: 12 additions & 12 deletions ports/rocksdb/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,17 @@ string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" ROCKSDB_BUILD_SHARED)

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
"lz4" WITH_LZ4
"snappy" WITH_SNAPPY
"zlib" WITH_ZLIB
"zstd" WITH_ZSTD
"bzip2" WITH_BZ2
"tbb" WITH_TBB
INVERTED_FEATURES
"tbb" CMAKE_DISABLE_FIND_PACKAGE_TBB
"jemalloc" WITH_JEMALLOC
yurybura marked this conversation as resolved.
Show resolved Hide resolved
"snappy" WITH_SNAPPY
"lz4" WITH_LZ4
"zlib" WITH_ZLIB
"zstd" WITH_ZSTD
"bzip2" WITH_BZ2
"numa" WITH_NUMA
"tbb" WITH_TBB
"force-sse42" FORCE_SSE42
"force-avx" FORCE_AVX
"force-avx2" FORCE_AVX2
)

vcpkg_cmake_configure(
Expand All @@ -35,16 +38,13 @@ vcpkg_cmake_configure(
-DWITH_TESTS=OFF
-DWITH_BENCHMARK_TOOLS=OFF
-DWITH_TOOLS=OFF
-DWITH_FOLLY_DISTRIBUTED_MUTEX=OFF
-DUSE_RTTI=1
-DUSE_RTTI=ON
-DROCKSDB_INSTALL_ON_WINDOWS=ON
-DFAIL_ON_WARNINGS=OFF
-DWITH_MD_LIBRARY=${WITH_MD_LIBRARY}
-DPORTABLE=ON
-DCMAKE_DEBUG_POSTFIX=d
-DROCKSDB_BUILD_SHARED=${ROCKSDB_BUILD_SHARED}
-DCMAKE_DISABLE_FIND_PACKAGE_NUMA=TRUE
-DCMAKE_DISABLE_FIND_PACKAGE_gtest=TRUE
-DCMAKE_DISABLE_FIND_PACKAGE_Git=TRUE
yurybura marked this conversation as resolved.
Show resolved Hide resolved
${FEATURE_OPTIONS}
)
Expand Down
42 changes: 36 additions & 6 deletions ports/rocksdb/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "rocksdb",
"version": "7.9.2",
"port-version": 1,
"description": "A library that provides an embeddable, persistent key-value store for fast storage",
"homepage": "https://github.com/facebook/rocksdb",
"license": "GPL-2.0-only OR Apache-2.0",
Expand All @@ -15,41 +16,70 @@
}
],
"default-features": [
"liburing",
"zlib"
],
"features": {
"bzip2": {
"description": "bzip2 support in rocksdb",
"description": "build with bzip2",
"dependencies": [
"bzip2"
]
},
"force-avx": {
"description": "force building with AVX"
},
"force-avx2": {
"description": "force building with AVX2"
},
"force-sse42": {
"description": "force building with SSE 4.2"
},
yurybura marked this conversation as resolved.
Show resolved Hide resolved
"jemalloc": {
"description": "build with JeMalloc",
"dependencies": [
"jemalloc"
]
},
"liburing": {
"description": "build with liburing",
"dependencies": [
{
"name": "liburing",
"platform": "linux"
}
]
},
yurybura marked this conversation as resolved.
Show resolved Hide resolved
"lz4": {
"description": "lz4 support in rocksdb",
"description": "build with lz4",
"dependencies": [
"lz4"
]
},
"numa": {
"description": "build with NUMA policy support",
"supports": "linux"
},
"snappy": {
"description": "snappy support in rocksdb",
"description": "build with SNAPPY",
"dependencies": [
"snappy"
]
},
"tbb": {
"description": "tbb support in rocksdb",
"description": "build with Threading Building Blocks (TBB)",
"dependencies": [
"tbb"
]
},
"zlib": {
"description": "zlib support in rocksdb",
"description": "build with zlib",
"dependencies": [
"zlib"
]
},
"zstd": {
"description": "zstd support in rocksdb",
"description": "build with zstd",
"dependencies": [
"zstd"
]
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -6770,7 +6770,7 @@
},
"rocksdb": {
"baseline": "7.9.2",
"port-version": 0
"port-version": 1
},
"rpclib": {
"baseline": "2.3.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/r-/rocksdb.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "611a81a64c15f836edc7aea45736ff4e3702d8eb",
"version": "7.9.2",
"port-version": 1
},
{
"git-tree": "9ab4b0ca16f88be2bcddaab354944e2650a33b77",
"version": "7.9.2",
Expand Down