Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Rnm Normalization. #86

Open
pdradx opened this issue Dec 12, 2023 · 1 comment
Open

Wrong Rnm Normalization. #86

pdradx opened this issue Dec 12, 2023 · 1 comment
Assignees
@donglixp

Comments

@pdradx
Copy link

pdradx commented Dec 12, 2023 •
edited
Loading

The fix of normalization Rnm is totally wrong.
The added max value in clam needed because of wrong placement of abs() operation.
More thorough explanation I put here:
fdd8838#commitcomment-134758047

Commented commit brokes the only place where it was right!
@pdradx
Copy link
Author

pdradx commented Dec 12, 2023 •
edited
Loading

But if it is right - the paper needs fix in corresponding section, describing normalization tricks.

@shumingma shumingma assigned shumingma and donglixp and unassigned donglixp and shumingma Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donglixp donglixp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@donglixp @pdradx @shumingma