Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT -f <myApp.exe> causes glitched window #13181

Closed
jredfox opened this issue May 26, 2022 · 6 comments
Closed

WT -f <myApp.exe> causes glitched window #13181

jredfox opened this issue May 26, 2022 · 6 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered

Comments

@jredfox
Copy link

jredfox commented May 26, 2022

Windows Terminal version

1.12.10982.0

Windows build number

10.0.19044.1706

Other Software

java.exe

Steps to reproduce

wt -f java --> produces a window in which you cannot close there is no x button.
wt --focus java --> produces a window in which you cannot close there is no x button.

Expected Behavior

it open up the default profile with the batch icon on the top left and it execute normally. wt java will produce the proper result

Actual Behavior

bordless window you cannot close.
java 5_25_2022 10_09_28 PM

running wt new-tab -f java seems to fix it. but why isn't' there an error message if -f requires the new tab?

@jredfox jredfox added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 26, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 26, 2022
@zadjii-msft
Copy link
Member

This is totally by design. -f before any subcommands opens the window in fullscreen mode. There's no frame in fullscreen mode by design. There's a variety of QoL improvements to fullscreen mode we're tracking in #3486

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2022
@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered labels May 26, 2022
@jredfox
Copy link
Author

jredfox commented May 26, 2022 via email

@jredfox
Copy link
Author

jredfox commented May 26, 2022

@zadjii-msft reproducable with wt --focus java

@zadjii-msft
Copy link
Member

Derp.

-F is fullscreen.

-f is "focus mode". It should still have borders around the window though. Something that looks like:
image

You should be able to leave focus mode with the "Toggle Focus Mode" command in the Command Palette

@jredfox
Copy link
Author

jredfox commented May 26, 2022

Capture
@zadjii-msft I fail to see how using --focus without a new tab creates a borderless app with no x button is intended to work that way that's not even in fullscreen. it should either say hey error can't focus without a tab specified or it should create a tab with the default profile like wt with no additional params does. the --focus usual behavior is to focus the right tab or window so the user doesn't have to look for it.

@zadjii-msft
Copy link
Member

Focus mode is a feature. An intentional mode for the window without any other chrome. There are still tabs in focus mode, they're just hidden.

fomo-sample-000

the --focus usual behavior is to focus the right tab or window so the user doesn't have to look for it

Pretty sure that --focus has been used to launch in focus mode for the Terminal since we introduced that argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

2 participants