Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default template points to old Action with MSVC layout error #33

Open
patrikhuber opened this issue Apr 9, 2023 · 4 comments
Open

Default template points to old Action with MSVC layout error #33

patrikhuber opened this issue Apr 9, 2023 · 4 comments

Comments

@patrikhuber
Copy link

Hi,

I've created a new msvc code analysis action a couple days ago using the GitHub UI. The template msvc.yml that it created pointed to an old commit of this repo that resulted in an MSVC layout error when trying to run it. Google wasn't very helpful unfortunately but luckily I found #22, and after pointing my msvc.yml to the latest commit in this repo, it then worked.

I'd encourage you to update the template on GitHub.com so that users that create this action have an easier ride.

@Blake-Madden
Copy link

Thank you! Using the example from the Readme here instead of the template fixed this and some other issues for me. The default template is also not defining a Cmake configuration (e.g., Debug) and that also causes errors.

CorrodedCoder added a commit to CorrodedCoder/Blades-of-Exile that referenced this issue Nov 26, 2023
Attempt to resolve MSVC Layout Error as something like described here, by providing a confiuguration: microsoft/msvc-code-analysis-action#33
@CorrodedCoder
Copy link

I added this action today and ran straight into "Error: Unknown MSVC toolset layout".

I attempted to make adjustments as per the Readme by specifying a buildConfiguration and I get "Warning: Unexpected input(s) 'buildConfiguration', valid inputs are ['cmakeBuildDirectory', 'ruleset', 'ignoredTargetPaths', 'ignoredIncludePaths', 'ignoreSystemHeaders', 'resultsPath', 'loadImplicitCompilerEnv', 'additionalArgs']"

Is there an example of this currently working in a project right now that I can compare against my own? (which can be found here https://github.com/CorrodedCoder/Blades-of-Exile )

@Blake-Madden
Copy link

I added this action today and ran straight into "Error: Unknown MSVC toolset layout".

I attempted to make adjustments as per the Readme by specifying a buildConfiguration and I get "Warning: Unexpected input(s) 'buildConfiguration', valid inputs are ['cmakeBuildDirectory', 'ruleset', 'ignoredTargetPaths', 'ignoredIncludePaths', 'ignoreSystemHeaders', 'resultsPath', 'loadImplicitCompilerEnv', 'additionalArgs']"

Is there an example of this currently working in a project right now that I can compare against my own? (which can be found here https://github.com/CorrodedCoder/Blades-of-Exile )

This is mine that works (results will appear in the project's Security tab).

https://github.com/Blake-Madden/OleanderStemmingLibrary/blob/master/.github/workflows/msvc.yml

@CorrodedCoder
Copy link

CorrodedCoder commented Nov 29, 2023

That's great thanks @Blake-Madden - that really helped get me up and running!

It seems like issue is that the template specifies:
microsoft/msvc-code-analysis-action@04825f6d9e00f87422d6bf04e1a38b1f3ed60d99
Where as your working link (and the example provided in the ReadMe.md file) specify:
microsoft/[email protected]

That made all the difference to me, so I'm not sure why the marketplace autogenerated code is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants