Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use distinct runs per compile target #25

Open
jsoref opened this issue Oct 11, 2022 · 2 comments
Open

Don't use distinct runs per compile target #25

jsoref opened this issue Oct 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jsoref
Copy link

jsoref commented Oct 11, 2022

github/codeql-action#1058 (comment)

@d-winsor
Copy link
Contributor

Analysis runs inside the compiler, so the analysis tool is actually being run as many times as there are compile targets. We can have the javascript merge the SARIF content into one run to work-around this.

The limitation of number of runs feels a little arbitrary given the flexible nature of SARIF but GitHub Code Scanning is the main selling point of the action so I will update the tool to merge the results into a single run.

@d-winsor d-winsor self-assigned this Oct 11, 2022
@d-winsor d-winsor added the enhancement New feature or request label Oct 11, 2022
@jsoref
Copy link
Author

jsoref commented Oct 11, 2022

Hey, I'm not endorsing this or any other arbitrary limit :). You're welcome and perhaps even encouraged to talk to that other MS division about it.

(I'm in the process of setting up my own sarif generation and am hitting all sorts of fun edges...)

Anyway, thanks for taking this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants