You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The action was configured with: ignoredPaths: ${{ github.workspace }}/src/external/gsl;${{ github.workspace }}/src/external/tinyxml2
Which was expanded to: ignoredPaths: D:\a\npp-papyrus\npp-papyrus/src/external/gsl;D:\a\npp-papyrus\npp-papyrus/src/external/tinyxml2
However, file 'tinyxml2.cpp' under D:\a\npp-papyrus\npp-papyrus\src\external\tinyxml2 directory was still analyzed: Running analysis on: D:\a\npp-papyrus\npp-papyrus\src\external\tinyxml2\tinyxml2.cpp
It looks like ignoredPaths is currently only targeting includes and CMake targets, not source files themselves. Typically, you would build a CMake target in an external path rather than collect and compile the sources files so this was missed.
It makes sense to also ignore source files so I will add this feature to the action.
See https://github.com/blu3mania/npp-papyrus/actions/runs/3205014421/jobs/5236999872
The action was configured with:
ignoredPaths: ${{ github.workspace }}/src/external/gsl;${{ github.workspace }}/src/external/tinyxml2
Which was expanded to:
ignoredPaths: D:\a\npp-papyrus\npp-papyrus/src/external/gsl;D:\a\npp-papyrus\npp-papyrus/src/external/tinyxml2
However, file 'tinyxml2.cpp' under D:\a\npp-papyrus\npp-papyrus\src\external\tinyxml2 directory was still analyzed:
Running analysis on: D:\a\npp-papyrus\npp-papyrus\src\external\tinyxml2\tinyxml2.cpp
In a later test, the config was changed to use relative paths:
ignoredPaths: src/external/gsl;src/external/tinyxml2
However, the issue was still there (see https://github.com/blu3mania/npp-papyrus/actions/runs/3205291289/jobs/5237620319)
The text was updated successfully, but these errors were encountered: