Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoredPaths doesn't work as expected #24

Open
blu3mania opened this issue Oct 7, 2022 · 2 comments
Open

ignoredPaths doesn't work as expected #24

blu3mania opened this issue Oct 7, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@blu3mania
Copy link

blu3mania commented Oct 7, 2022

See https://github.com/blu3mania/npp-papyrus/actions/runs/3205014421/jobs/5236999872

The action was configured with:
ignoredPaths: ${{ github.workspace }}/src/external/gsl;${{ github.workspace }}/src/external/tinyxml2
Which was expanded to:
ignoredPaths: D:\a\npp-papyrus\npp-papyrus/src/external/gsl;D:\a\npp-papyrus\npp-papyrus/src/external/tinyxml2
However, file 'tinyxml2.cpp' under D:\a\npp-papyrus\npp-papyrus\src\external\tinyxml2 directory was still analyzed:
Running analysis on: D:\a\npp-papyrus\npp-papyrus\src\external\tinyxml2\tinyxml2.cpp

In a later test, the config was changed to use relative paths:
ignoredPaths: src/external/gsl;src/external/tinyxml2
However, the issue was still there (see https://github.com/blu3mania/npp-papyrus/actions/runs/3205291289/jobs/5237620319)

@d-winsor d-winsor added the enhancement New feature or request label Oct 11, 2022
@d-winsor
Copy link
Contributor

d-winsor commented Oct 11, 2022

It looks like ignoredPaths is currently only targeting includes and CMake targets, not source files themselves. Typically, you would build a CMake target in an external path rather than collect and compile the sources files so this was missed.

It makes sense to also ignore source files so I will add this feature to the action.

@d-winsor d-winsor self-assigned this Oct 11, 2022
@mloskot
Copy link

mloskot commented Feb 4, 2023

Any news on the ignorePaths improvements?

In nanodbc we do

ignoredPaths: ${{ github.workspace }}/test/catch

to make analyser ignore headers of Catch test framework, but it does not work, and https://github.com/nanodbc/nanodbc/security lists issues for Catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants