[WIP] Kiota search apicurio #3670
Conversation
There was a problem hiding this comment.
I think this is a really good start! And I'm happy to see another kiota client in kiota too, full circle 🥳
For what I suggest we call "user configuration" (configuration that is likely to vary a lot on a per user base), have a look at the "login github" command. The design here was intended to support private GitHub enterprise instances over time.
The main change I'd make though is for some reason that configuration is stored in TEMP/TMP when it should be stored in AppData instead.
src/Kiota.Builder/SearchProviders/Apicurio/ApicurioSearchProvider.cs
Outdated
Show resolved
Hide resolved
src/Kiota.Builder/SearchProviders/Apicurio/ApicurioSearchProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Biret <[email protected]>
Yup! Super nice :-)
I'll try to figure something out, will get back if I get stuck, thanks! 👍 |
Source generators have lots of serious limitations and odd behaviours at the moment, we're purposefully staying away from them for the time being. |
This is an initial(wip) integration of Apicurio as a search provider for Kiota.
It was briefly discussed with @baywet during the community meeting last time.
This implementation already "works"(against unauthenticated instances) but I think we need a little more to get it in a usable state:
kiota search --helpdoesn't show the specific configurations (i.e. same for github) and passing those seems to be a bit tricky, or, at least, you should know aboutappsettingsetc..With Apicurio Registry we need to pass a few options and they should be easily discoverable by the users, I'm looking for proposals on how to design this (no super strong C# dev skills here 😊 ).
Often Apicurio Registry instances are protected with Oidc Authentication, we need slightly better integration (as mentioned here ) to get this streamlined.
I'll go ahead and propose something in
kiota-javathat I will eventually port to dotnet.