Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union Models rely on schema having a title #835

Closed
darrelmiller opened this issue Nov 14, 2021 · 2 comments
Closed

Union Models rely on schema having a title #835

darrelmiller opened this issue Nov 14, 2021 · 2 comments
Assignees
@baywet
Labels
duplicate This issue or pull request already exists generator Issues or improvements relater to generation capabilities.

Comments

@darrelmiller
Copy link
Member

kiota/src/Kiota.Builder/KiotaBuilder.cs

Line 714 in efb42b4

var className = currentSchema.GetSchemaTitle();

This code is missing the fallback that uses the schema key if there is no title.
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Nov 15, 2021
@baywet
Copy link
Member

baywet commented Nov 15, 2021

Could you provide a repro schema please?

@baywet baywet added this to Kiota Feb 18, 2022
@baywet baywet moved this to Todo in Kiota Feb 18, 2022
@baywet baywet mentioned this issue Feb 28, 2022
Closed
@baywet
Copy link
Member

baywet commented Mar 14, 2022

closing this as a duplicate of #1270

@baywet baywet closed this as completed Mar 14, 2022
Repository owner moved this from Todo to Done in Kiota Mar 14, 2022
@baywet baywet added duplicate This issue or pull request already exists and removed needs more information labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
duplicate This issue or pull request already exists generator Issues or improvements relater to generation capabilities.
Projects
Kiota
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darrelmiller @baywet