Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python - doc comments with """ leads to invalid code #5636

Closed
baywet opened this issue Oct 18, 2024 · 0 comments · Fixed by #5729
Closed

Python - doc comments with """ leads to invalid code #5636

baywet opened this issue Oct 18, 2024 · 0 comments · Fixed by #5729
Assignees
@andrueastman
Labels
Python type:bug A broken experience type:regression A bug from previous release WIP
Milestone
Kiota v1.21

Comments

@baywet
Copy link
Member

baywet commented Oct 18, 2024 

kiota generate -d https://raw.githubusercontent.com/APIs-guru/openapi-directory/gh-pages/v2/specs/github.com/api.github.com/1.1.4/openapi.json -l Python

Leads to

integration_test/client/orgs/item/actions/secrets/item/with_secret_name_item_request_builder.py:66: error: invalid syntax  [syntax]

This is caused by the present of """ in the doc comment, this value should be escaped or stripped.
@baywet baywet added Python type:bug A broken experience type:regression A bug from previous release labels Oct 18, 2024
@baywet baywet added this to Kiota Oct 18, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Oct 18, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Oct 18, 2024
@andrueastman andrueastman self-assigned this Nov 5, 2024
@andrueastman andrueastman mentioned this issue Nov 5, 2024
Merged
@andrueastman andrueastman moved this from Todo 📃 to In Progress 🚧 in Kiota Nov 5, 2024
@andrueastman andrueastman moved this from In Progress 🚧 to In Review 💭 in Kiota Nov 8, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Nov 13, 2024
@baywet baywet added this to the Kiota v1.21 milestone Dec 5, 2024
@BrewTestBot BrewTestBot mentioned this issue Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrueastman andrueastman

Labels
Python type:bug A broken experience type:regression A bug from previous release WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.21
Development

Successfully merging a pull request may close this issue.

fixes python generation with comment opening/closing tags microsoft/kiota
2 participants
@andrueastman @baywet