openapi from odata error

[marcioatws]

I generated the openapi spec from an odata application and the typescript client in kiota didn't work with the url parentheses. for example, for the url http://aaaa.bbb/entities({id}) in the model, a method called entitiesWithId(type | undefined) was generated and when used it causes an error that entitiesWithId is not a function. i can generate some code for error reproduction if need it.

Another situation is that using the "strict" option in the typescript settings, the following error message is generated in all models:

src/app/models/contratoAggregate/index.ts:125:95 - error TS2345: Argument of type '(writer: SerializationWriter, contrato?: Partial | undefined) => void' is not assignable to parameter of type 'ModelSerializerFunction'.
Types of parameters 'contrato' and 'value' are incompatible.
Type 'Partial | null | undefined' is not assignable to type 'Partial | undefined'.
Type 'null' is not assignable to type 'Partial | undefined'.

writer.writeCollectionOfObjectValues<Contrato>("value", contratoCollectionResponse.value, serializeContrato);

[baywet]

Hi @marcioatws
Thank you for using kiota and for reaching out.

For the parameter type this was introduced by microsoft/kiota-typescript#1248 and needs the corresponding generator changes to function properly #5163. You can use the latest preview release and re-generate the client.

For the non-existent function, can you provide a repro description please?

[marcioatws]

sry for late response.

Repo for error: https://github.com/marcioatws/kiota-odata-error
Kiota version: 1.17.0+1eb16cd65853c17179e2dde3ae6098135deacf55

I will try to summarize the issue again.

Sample Backend Controller:

app.MapGet("/products/{id:int}", (int id) =>
{
    var product = products.FirstOrDefault(p => p.Id == id);
    return product is not null ? Results.Ok(product) : Results.NotFound();
});

// url format in odata spec 
app.MapGet("/products({id:int})", (int id) =>
{
    var product = products.FirstOrDefault(p => p.Id == id);
    return product is not null ? Results.Ok(product) : Results.NotFound();
});

Client Generation Command:

kiota generate --clean-output --exclude-backward-compatible --language typescript --openapi "xxx" --output "xxx"

TypeScript Client Output:

export interface ApiClient extends BaseRequestBuilder<ApiClient> {
    /**
     * The products property
     */
    get products(): ProductsRequestBuilder;
    /**
     * Builds and executes requests for operations under /products({id})
     * @param id The path parameter: id
     * @returns {ProductsWithIdRequestBuilder}
     */
     productsWithId(id: number | undefined) : ProductsWithIdRequestBuilder;
}

However, calling productsWithId results in a "not a function" error.

sorry for my english, it's not my language.

[baywet]

Thank you for the additional information.
I have transferred the issue to the main repository since it's a generation issue.
I have authored #5248 to address the issue.
Once the pull request is merged, you'll need to regenerate the client from the upcoming preview (Thursday) or build kiota locally.
Additionally, here is a patch file that illustrates the changes on the client.
patchfile.patch
Let us know if you have any additional comments or questions.