Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix dotnet types with global:: so that we don't get conflicts with property names #5020

Closed
jakejscott opened this issue Jul 24, 2024 · 2 comments
Labels
Csharp Pull requests that update .net code status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience

Comments

@jakejscott
Copy link

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Nuget tool

Client library/SDK language

Csharp

Describe the bug

We are getting namespace error's because the models are not prefixed with global::

Here's an example of the problem

kiota-error

And here's how it could be fixed by prefixing models with global:: like people do with source generators.

kiota-not-error

Expected behavior

Code should compile and not have any issues

How to reproduce

It happens across multiple apis that we have

Open API description file

No response

Kiota Version

1.15.0

Latest Kiota version known to work for scenario above?(Not required)

No response

Known Workarounds

Fixing it manually

Configuration

  • Windows

Debug output

N/A

Other information

N/A

@jakejscott jakejscott added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Jul 24, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jul 24, 2024
@msgraph-bot msgraph-bot bot added the Csharp Pull requests that update .net code label Jul 24, 2024
@jakejscott
Copy link
Author

This issue is related to #4796

@jakejscott
Copy link
Author

I think this has been fixed in kiota 1.16.0
https://github.com/microsoft/kiota/releases/tag/v1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience
Projects
Archived in project
Development

No branches or pull requests

1 participant