Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect open folder in VS Code is TTK project and change output path for Copilot Plugin #4766

Closed
Tracked by #4293
jthake opened this issue Jun 3, 2024 · 3 comments · Fixed by #4958
Closed
Tracked by #4293
Assignees
Labels
type:feature New experience request vscode-extension Work related to the vscode-extension
Milestone

Comments

@jthake
Copy link

jthake commented Jun 3, 2024

Is your feature request related to a problem? Please describe the problem.

If I create a copilot plugin in Kiota when my VS Code open folder is a teams toolkit project, it creates the manfiest by default in root folder.

Client library/SDK language

None

Describe the solution you'd like

If I have a Teams toolkit project open, there are various out of the box folder structures like "appPackage" that exist. The plugin manifests that TTK creates go here by default. Kiota should do the same.

Additional context

No response

@jthake jthake added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Jun 3, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jun 3, 2024
@andrueastman
Copy link
Member

Thanks for raising this @jthake

For context, is the request here to change the location of the workspace.json file as well? Or just the default output path of the generated plugin when generating the plugin?

@andrueastman andrueastman added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jun 4, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Proposed 💡 in Kiota Jun 4, 2024
@sebastienlevert
Copy link
Contributor

I'd say just the output path should understand that you're in a TTK project and suggest appPackage as the default ouput.

@andrueastman andrueastman removed the status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close label Jun 5, 2024
@andrueastman andrueastman added this to the Backlog milestone Jun 5, 2024
@sebastienlevert sebastienlevert moved this from Proposed 💡 to Todo 📃 in Kiota Jun 6, 2024
@baywet baywet added the vscode-extension Work related to the vscode-extension label Jun 11, 2024
@ElinorW ElinorW self-assigned this Jun 19, 2024
@ElinorW ElinorW linked a pull request Jul 17, 2024 that will close this issue
@ElinorW
Copy link
Contributor

ElinorW commented Jul 26, 2024

Fixed in #4958

@ElinorW ElinorW closed this as completed Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New experience request vscode-extension Work related to the vscode-extension
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants