Python attributes are Optional, despite required in OAS schema

[tarilabs]

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Mac executable

Client library/SDK language

Python

Describe the bug

I have some OAS properties as required.
When generating Python, the models are rendered with Optional attributes, for example Optional[str] = None.

i.e.:

components:
  schemas:
    Example:
      type: object
      properties:
        name:
          type: string
          example: Example Name
        description:
          type: string
          example: This is an example description.
        value:
          type: number
          example: 42.0
      required:
        - name
        - value

gets rendered as:

@dataclass
class Example(AdditionalDataHolder, Parsable):
    # Stores additional data not described in the OpenAPI description found when deserializing. Can be used for serialization as well.
    additional_data: Dict[str, Any] = field(default_factory=dict)

    # The description property
    description: Optional[str] = None
    # The name property
    name: Optional[str] = None
    # The value property
    value: Optional[float] = None

Where instead expected for name and value not to be Optional attributes.

Expected behavior

If an OAS property is required,
in the target language it should be required too.

How to reproduce

first example:

• required: https://github.com/tarilabs/demo20240531-kiotaRequired/blob/ea8c71d67933edc042d1f5259cf77d456fe0c78e/required.yaml#L61-L63
• but rendered as Optional https://github.com/tarilabs/demo20240531-kiotaRequired/blob/ea8c71d67933edc042d1f5259cf77d456fe0c78e/myclient/models/example.py#L14-L16

second example:

• required: https://github.com/tarilabs/demo20240531-kiotaRequired/blob/ea8c71d67933edc042d1f5259cf77d456fe0c78e/required.yaml#L79-L81
• but rendered as optional https://github.com/tarilabs/demo20240531-kiotaRequired/blob/ea8c71d67933edc042d1f5259cf77d456fe0c78e/myclient/models/example2.py#L16-L18

Open API description file

No response

Kiota Version

1.15.0-preview.202405300001+76b8e1bdaf86000dc03cfdec19528192745ff3b4

Latest Kiota version known to work for scenario above?(Not required)

No response

Known Workarounds

No response

Configuration

No response

Debug output

No response

Other information

This might be also related to:

• [Multiple languages] properties are generated as nullable/optional, despite required/nullable usage in OAS schema #3911

and other target languages?

[baywet]

Hi @tarilabs
Thanks for the detailed information here.
Since it's a design choice on our end which is consistent across languages, and since there's already an issue opened for that #3911, I'm tempted to close it as duplicate to centralize the discussions.
Any objection?

[tarilabs]

Hi @baywet no objection, but #3911 in its title looked specific to C#, so that's the reason I created this one :)

👍

[baywet]

Thanks I'll update the title over there