CS8625 warnings on generated code

[andrueastman]

Related to #4692

There is still a minor problem that causes CS8625 warnings on code like the following:

#nullable enable
        public async Task<UntypedNode?> DeleteAsync(Action<RequestConfiguration<DefaultQueryParameters>>? requestConfiguration = default, CancellationToken cancellationToken = default)
        {
#nullable restore
#else
        public async Task<UntypedNode> DeleteAsync(Action<RequestConfiguration<DefaultQueryParameters>> requestConfiguration = default, CancellationToken cancellationToken = default)
        {
#endif
            var requestInfo = ToDeleteRequestInformation(requestConfiguration);
            return await RequestAdapter.SendAsync<UntypedNode>(requestInfo, /* CS8625 ==> */default, null, cancellationToken).ConfigureAwait(false);
        }

warning CS8625: Cannot convert null literal to non-nullable reference type

Without delving further to determine if this manual fixup causes other issues, the warning goes away when patched as follows:

return await RequestAdapter.SendAsync<UntypedNode>(requestInfo, default!, null, cancellationToken).ConfigureAwait(false);

However, in my opinion, the generated code should compile without warnings and should not require manual fixups.

Originally posted by @johnholliday in #4692 (comment)

[baywet]

Thanks for creating this.
This second parameter is of type ParsableFactory<ModelType> factory. Which I'm suspecting passing "default" actually translates to "null". We should instead be passing UntypedNode.CreateFromDiscriminatorValue. What do you think?

[andrueastman]

Yeah. You're totally right.
The evaluation of the parameter should pass the UntypedNode.CreateFromDiscriminatorValue in this case.

[andrueastman]

After double checking this with the latest version, the generator already generates parameter correctly as UntypedNode.CreateFromDiscriminatorValue.

Testing with description from https://github.com/microsoft/kiota/files/15387323/Kiota.Test.zip also yields no CS8625 warnings as well.

@johnholliday Any chance you can confirm this is still an issue?

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.