Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest validator as part of the microsoft plugin generation #4491

Closed
maisarissi opened this issue Apr 15, 2024 · 2 comments · Fixed by #4499
Closed

Add manifest validator as part of the microsoft plugin generation #4491

maisarissi opened this issue Apr 15, 2024 · 2 comments · Fixed by #4499
Assignees
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Milestone

Comments

@maisarissi
Copy link
Contributor

When choosing "microsoft" as --type, we should make sure Kiota relies on Manifest validator library to validate and be sure we are generating a valid plugin.

@github-project-automation github-project-automation bot moved this to Todo 📃 in Kiota Apr 15, 2024
@andrueastman
Copy link
Member

Do we need to update the spec to include microsoft as an option

| `--type \| -t` | Yes | openai | The target type of plugin for the generated output files. Accepts multiple values. Possible values are `openai` and `apimanifest`. Defaults to `apimanifest`| Yes |

as #4416 is currently generating the microsoft plugin type when the parameter apimanifest type is passed?

@maisarissi
Copy link
Contributor Author

Specs are going to be updated to also add microsoft as a valid --type. The current output being generated when passing --type apimanifest is the desired outcome to when using microsoft.

@andrueastman andrueastman linked a pull request Apr 18, 2024 that will close this issue
@andrueastman andrueastman self-assigned this Apr 18, 2024
@andrueastman andrueastman moved this from Todo 📃 to In Progress 🚧 in Kiota Apr 18, 2024
@andrueastman andrueastman moved this from In Progress 🚧 to In Review 💭 in Kiota Apr 18, 2024
@andrueastman andrueastman added this to the Kiota v1.14 milestone Apr 18, 2024
@andrueastman andrueastman added the type:bug A broken experience label Apr 18, 2024
@baywet baywet closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Apr 19, 2024
@andrueastman andrueastman added the generator Issues or improvements relater to generation capabilities. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants