Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I should be able to generate API Manifest from Kiota #4447

Closed
maisarissi opened this issue Apr 4, 2024 · 2 comments · Fixed by #4499
Closed

I should be able to generate API Manifest from Kiota #4447

maisarissi opened this issue Apr 4, 2024 · 2 comments · Fixed by #4499
Assignees
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Milestone

Comments

@maisarissi
Copy link
Contributor

Today, when running Kiota CLI to generate plugins, I can do the following:

kiota plugin add --pn sunoWithExtensions --openapi .\suno-openapi-with-extensions.yml --type apimanifest

However, the output generated is not an API Manifest.

When choosing --type apimanifest, the output file should be an API Manifest.

@github-project-automation github-project-automation bot moved this to Todo in Kiota Apr 4, 2024
@andrueastman andrueastman added the type:bug A broken experience label Apr 5, 2024
@andrueastman andrueastman added this to the Kiota v1.14 milestone Apr 5, 2024
@andrueastman andrueastman self-assigned this Apr 15, 2024
@andrueastman
Copy link
Member

To clarify here according to the spec, what is expected is that since --output is optional and not specified in the above command, we should generate in the ./output folder a sunoWithExtensions-apimanfest.json

The apimanifest.json is currently already generated in the ./kiota folder.

@maisarissi
Copy link
Contributor Author

maisarissi commented Apr 17, 2024

According to the spec, in addition to the already generated apimanifest.json in the ./kiota folder, when choosing --type apimanifest, Kiota should generate a specific apimanifest to the given --open-api named {plugin-name}-apimanifest.json, which in this case is sunoWithExtensions-apimanifest.json in the ./output folder. However, we also need to generate the apimanifest.json in the ./kiota folder.

The apimanifest.json in the ./kiota folder will be a concatenated version of all clients and plugins, that can be used, for example, as a contract with the tenant admin to show all the APIs, endpoints, permissions your solution may need. And one may need a specific apimanifest for the plugin they are creating. A scenario for that is, Semantic Kernel has a under development skill that accepts an API Manifest as input. So one may want to create a specific API Manifest using Kiota to use in SK.

@andrueastman andrueastman moved this from Todo 📃 to In Progress 🚧 in Kiota Apr 18, 2024
@andrueastman andrueastman linked a pull request Apr 18, 2024 that will close this issue
@baywet baywet closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Apr 19, 2024
@andrueastman andrueastman added the generator Issues or improvements relater to generation capabilities. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants