Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating a plugin, --type should shows as required #4417

Closed
maisarissi opened this issue Mar 28, 2024 · 2 comments · Fixed by #4484
Closed

When generating a plugin, --type should shows as required #4417

maisarissi opened this issue Mar 28, 2024 · 2 comments · Fixed by #4484
Assignees
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Milestone

Comments

@maisarissi
Copy link
Contributor

When running kiota plugin add, the command should show all required parameters, --openapi, --plugin-name and --type

image

@github-project-automation github-project-automation bot moved this to Todo in Kiota Mar 28, 2024
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels Mar 29, 2024
@baywet baywet added this to the Kiota v1.14 milestone Mar 29, 2024
@andrueastman andrueastman self-assigned this Apr 9, 2024
@andrueastman
Copy link
Member

@maisarissi Should we be updating the spec to remove the default value?

I believe the issue here is that if its required and has a default value, not providing the value will fall back to the openAi type.
https://github.com/microsoft/kiota/blob/main/specs/cli/plugin-add.md?plain=1#L49

@maisarissi
Copy link
Contributor Author

Spec updated: #4477

@andrueastman andrueastman moved this from Todo 📃 to In Review 💭 in Kiota Apr 11, 2024
@andrueastman andrueastman linked a pull request Apr 11, 2024 that will close this issue
@andrueastman andrueastman moved this from In Review 💭 to In Progress 🚧 in Kiota Apr 11, 2024
@baywet baywet closed this as completed Apr 16, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants