-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused type imports Parsable and ParsableFactory are causing build fail #4397
Comments
Hi @sher The doc comments are being written here
And things are tested at the following places
kiota/tests/Kiota.Builder.Tests/Writers/TypeScript/CodeClassDeclarationWriterTests.cs Line 44 in 39b3cde
kiota/tests/Kiota.Builder.Tests/Writers/TypeScript/CodeInterfaceDeclarationWriterTests .cs Line 38 in 39b3cde
With all that information in mind, would you be willing to submit a pull request to address this? |
Actually, let me rephrase that suggestion, this is probably too big of a suppression because semantic checks will also be disbaled. This will make it much harder to catch any regression at build time.
|
Kiota generated request builder imports several types from abstractions package.
Among them
Parsable
andParsableFactory
are never referenced in the generated code.This is failing to build in projects where
tsconfig.json
hasnoUnusedLocals: true
such as default Vitejs tsconfig.json.The text was updated successfully, but these errors were encountered: