Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Quotes never escaped in some corner cases. #4229

Closed
SilasKenneth opened this issue Feb 26, 2024 · 1 comment · Fixed by #4243
Closed

PHP Quotes never escaped in some corner cases. #4229

SilasKenneth opened this issue Feb 26, 2024 · 1 comment · Fixed by #4243
Assignees
@SilasKenneth
Labels
PHP type:bug A broken experience
Milestone
Kiota v1.12

Comments

@SilasKenneth
Copy link
Member

In some corner cases, single quotes are not escaped correctly.

$requestInfo->urlTemplate = '{+baseurl}/app/onlineMeetings(joinWebUrl='{joinWebUrl}')'
@SilasKenneth SilasKenneth added the type:bug A broken experience label Feb 26, 2024
@SilasKenneth SilasKenneth added this to the Kiota v1.12 milestone Feb 26, 2024
@SilasKenneth SilasKenneth self-assigned this Feb 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in Kiota Feb 26, 2024
@SilasKenneth SilasKenneth moved this from Todo to In Progress in Kiota Feb 26, 2024
@baywet baywet added the PHP label Feb 26, 2024
@baywet
Copy link
Member

baywet commented Feb 26, 2024

This might already have been addressed by #4218 but it's worth double checking

@SilasKenneth SilasKenneth linked a pull request Feb 26, 2024 that will close this issue
Fix escaping quotes in urlTemplate in PHP. #4243
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilasKenneth SilasKenneth

Labels
PHP type:bug A broken experience
Projects
Kiota
Archived in project
Milestone
Kiota v1.12
Development

Successfully merging a pull request may close this issue.

Fix escaping quotes in urlTemplate in PHP. microsoft/kiota
2 participants
@baywet @SilasKenneth