C# - Kiota swallows exception body when undocumented exception is thrown

[Ksdmg]

When no errorMapping exists, the response body does not get included in the thrown ApiExcepion:

https://github.com/microsoft/kiota-http-dotnet/blob/3c35d1c3c350c4b208e46b7c8bf8c93d518df916/src/HttpClientRequestAdapter.cs#L399C31-L399C31

I think you should include the full HttpResponseMessage as it is really helpful if you face undocumented exceptions.

[darrelmiller]

Would you be OK with the response body as a string? We can't return the native type as we don't want to take a dependency on it.

[Ksdmg]

Yes a simple string in the exception would help alot.
My proposed solution would be to add an ExceptionHandler as a QueryOption. This would allow us to create a custom exception handler that handles the payload without throwing.

[baywet]

@darrelmiller what would you want to be done when the payload is large and/or is "not a string"? (let's imagine the client gets an image back).
@Ksdmg this is something you'd be able to do today by implementing a custom middleware handler and a custom query option + inserting the handler in the middleware configuration of the HTTP client. Is this something you'd want to explore to provide a demonstration?

[Ksdmg]

@baywet would be awesome if you could give me an example of how to do it. I tried to do it with the ResponseHandler but this leads to additional code that I need to put into every request because it does not return a value even if the request is successful.

[baywet]

Here is an example of the retry handler

and its option

I suggest you implement a "Default Error Mapping option & handler". The option would contain a dictionary of status code and type mapping.

Then you'd need to build your http client by inserting your new middleware in the collection

And lastly, when you make your request with the fluent API, you can pass the option thanks to the request configuration (client.Foo.Bar.GetAsync(x => x.Options.Add(MyOptionInstance))

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.