-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guid uri template path/query parameter values should be normalized to string #1113
Comments
Honestly I can't find file in kiota typescript in witch I should do this changes |
Can you help me @baywet ? |
If we look at the dotnet implementation we can see that the URI getter calls into an additional method that's missing in typescript and which is responsible for handling enum query/path parameters as other scalar but non trivial types (guid, etc...) This is effectively what we need to replicate int typescript You can then add unit tests here to prevent any future regression. Thank you for starting the pull request already! |
It seems hard for me and I'm not sure if I will be able to complete this but I'll try |
Also I don't understand this part with replication @baywet |
the std uri template library does not handle guids, and wont because it's not a standard API across languages and they don't want to bring on additional dependencies.
We should normalize the value to string (no curlies) before we pass it to the uri template engine.
Originally reported:
std-uritemplate/std-uritemplate#140
microsoft/kiota#4335
Example implementation https://github.com/microsoft/kiota-abstractions-dotnet/blob/5a93d126e9ce30ae332e65f30df7b941e7d7c265/src/RequestInformation.cs#L123
The text was updated successfully, but these errors were encountered: