Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guid uri template path/query parameter values should be normalized to string #245

Closed
baywet opened this issue Mar 19, 2024 · 1 comment · Fixed by #278
Closed

Guid uri template path/query parameter values should be normalized to string #245

baywet opened this issue Mar 19, 2024 · 1 comment · Fixed by #278
Assignees
Labels
bug Something isn't working Standard GitHub label Issue caused by core project dependency modules or library

Comments

@baywet
Copy link
Member

baywet commented Mar 19, 2024

the std uri template library does not handle guids, and wont because it's not a standard API across languages and they don't want to bring on additional dependencies.
We should normalize the value to string (no curlies) before we pass it to the uri template engine.
Originally reported:
std-uritemplate/std-uritemplate#140
microsoft/kiota#4335

Example implementation https://github.com/microsoft/kiota-abstractions-dotnet/blob/5a93d126e9ce30ae332e65f30df7b941e7d7c265/src/RequestInformation.cs#L123

@baywet baywet added bug Something isn't working Standard GitHub label Issue caused by core project dependency modules or library labels Mar 19, 2024
@baywet baywet added this to Kiota Mar 19, 2024
@github-project-automation github-project-automation bot moved this to Todo in Kiota Mar 19, 2024
@pjmagee
Copy link

pjmagee commented May 13, 2024

same for dates microsoft/kiota#4644

@andrueastman andrueastman self-assigned this May 21, 2024
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Standard GitHub label Issue caused by core project dependency modules or library
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants