Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Basic Authentication #472

Closed
thompson-tomo opened this issue Nov 15, 2024 · 3 comments
Closed

Add support for Basic Authentication #472

thompson-tomo opened this issue Nov 15, 2024 · 3 comments
Labels
Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:question An issue that's a question

Comments

@thompson-tomo
Copy link
Contributor

The API which i am using Kiota to generate a client for uses Basic auth however there is no included provider to implement basic auth, which is a common and wide spread provider.

As such it would be useful if this was provided as part of the base package.

@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Nov 15, 2024
@baywet
Copy link
Member

baywet commented Nov 15, 2024

Hi @thompson-tomo
Thank you for using kiota and for reaching out.

Kiota technically already supports it through the ApiKeyAuthenticationProvider

Setting an API key of "Basic base64(username:password)", parameter name of "Authorization" and location of Header would do the trick.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization#examples

Of course, we could always provide a derived class that does the setup for the developer to make it easier and more obvious.

Is this something you'd like to submit a pull request for provided some guidance?

@baywet baywet added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:question An issue that's a question labels Nov 15, 2024
@baywet baywet moved this from Needs Triage 🔍 to Waits for author 🔁 in Kiota Nov 15, 2024
@thompson-tomo
Copy link
Contributor Author

Sure I will put a pr through.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Nov 15, 2024
@baywet baywet added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed Needs: Attention 👋 labels Nov 18, 2024

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: No Recent Activity status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:question An issue that's a question
Projects
Archived in project
Development

No branches or pull requests

2 participants