Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-utils generate_surrogate_key macro fails for versions 1.4+ when only one field is supplied #251

Open
amychen1776 opened this issue Jul 23, 2024 · 0 comments

Comments

@amychen1776
Copy link
Contributor

When an user uses the macro with only one field supplied on the adapter versions 1.4 and above, it fails with the error message "The concat function requires 2 to 254 arguments". This works on dbt 1.3 and fails after 1.4. I suspect it's related to the migration in 1.4 from depending on the dbt-sqlserver adapter to dbt-fabric.

What I expect to happen is when a user has set surrogate_key_treat_nulls_as_empty_strings to true, the adapter will respect that.

https://github.com/dbt-labs/dbt-utils/blob/1.2.0/macros/sql/generate_surrogate_key.sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant