Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAuth does not work in 1.8 #250

Closed
dataders opened this issue Jul 22, 2024 · 2 comments
Closed

SQLAuth does not work in 1.8 #250

dataders opened this issue Jul 22, 2024 · 2 comments

Comments

@dataders
Copy link
Contributor

After dbt-synapse began to inhierit from dbt-fabric instead of dbt-sqlserver, SQLAuth was effectively removed from this adapter as it isn't supported within Fabric and therefore dbt-fabric.

#218 was opened to flag this. #225, opened to solve this issue was only merged to the v1.7.latest branch so that it could be backported. However, the master branch still is missing the old ConnectionManager class that #225 added.

You can see the difference in the files below:

@amychen1776
Copy link
Contributor

@prdpsvs would it be possible to get the fix merged into 1.8+? This is breaking several implementations.

@prdpsvs
Copy link
Contributor

prdpsvs commented Sep 6, 2024

@amychen1776 , @dataders , This is addressed in 1.8.1

@prdpsvs prdpsvs closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants