Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-synapse 1.8.0rc1 broken by dbt-fabric 1.8.3 #242

Closed
dataders opened this issue Apr 30, 2024 · 3 comments
Closed

dbt-synapse 1.8.0rc1 broken by dbt-fabric 1.8.3 #242

dataders opened this issue Apr 30, 2024 · 3 comments

Comments

@dataders
Copy link
Contributor

microsoft/dbt-fabric#156 modified the below macros to include a USE [database], which is not compatible with Azure Synapse:

  • fabric__list_relations_without_caching
  • fabric__get_relation_without_caching
  • fabric__drop_relation_script

Because the latest dbt-synapse (1.8.0rc1) dependency is compatibility pinned (~=) to 1.8.0rc1, it auto-picks up any new patches to 1.8, including the latest 1.8.3 which includes the changes in microsoft/dbt-fabric#156

dbt_fabric_requirement = "dbt-fabric~=1.8.0rc2"

@prdpsvs
Copy link
Contributor

prdpsvs commented May 20, 2024

@dataders , The synapse adapter has overrides for above macros in PR #245. Why are tests throwing the error - https://github.com/microsoft/dbt-synapse/actions/runs/9155466561/job/25168215613?

Did I miss something?

@amychen1776
Copy link
Contributor

@prdpsvs was this resolved?

@prdpsvs
Copy link
Contributor

prdpsvs commented Jun 25, 2024

@amychen1776 , yes

@prdpsvs prdpsvs closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants