From 7fadfffd313ca4c14a141813d9b1b7924645bd3e Mon Sep 17 00:00:00 2001 From: artc95 Date: Mon, 12 Feb 2024 15:20:47 +0100 Subject: [PATCH] alert to remove pyodbc from dev_requirements.txt, if using Windows --- CHANGELOG.md | 1 + CONTRIBUTING.md | 2 +- dev_requirements.txt | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e3773db..193369a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ #### Under the hood * Switch dependency from dbt-sqlserver to dbt-fabric (per https://github.com/dbt-msft/dbt-sqlserver/issues/441) + * if Windows, remove `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt ## v1.4.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd5ccd52..fb39952f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ pyenv activate dbt-synapse Install the development dependencies and pre-commit and get information about possible make commands: ```shell -make dev +make dev # if Windows, remove `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt make help ``` diff --git a/dev_requirements.txt b/dev_requirements.txt index 02e93bd0..06071e8d 100644 --- a/dev_requirements.txt +++ b/dev_requirements.txt @@ -5,7 +5,7 @@ pre-commit==2.21.0;python_version<"3.8" pre-commit==3.3.1;python_version>="3.8" pytest-dotenv==0.5.2 dbt-tests-adapter~=1.4.9 -pyodbc==4.0.39 --no-binary :all: +pyodbc==4.0.39 --no-binary :all: # if Windows, remove aiohttp==3.8.3 azure-mgmt-synapse==2.0.0 flaky==3.7.0