From 5fd1851c59f824f00a61f958d303bdd7c0e9ed3e Mon Sep 17 00:00:00 2001 From: artc95 <arthur@dataroots.io> Date: Wed, 14 Feb 2024 09:52:15 +0100 Subject: [PATCH] remove pyodbc from dev_requirements.txt, alert about pyodbc for Mac users --- CHANGELOG.md | 3 ++- CONTRIBUTING.md | 2 +- dev_requirements.txt | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 193369a6..6e1b2e67 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,8 @@ #### Under the hood * Switch dependency from dbt-sqlserver to dbt-fabric (per https://github.com/dbt-msft/dbt-sqlserver/issues/441) - * if Windows, remove `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt + * for Mac users, before running `make dev`, add `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt + * about pyodbc "Symbol not found: _SQLAllocHandle" error https://stackoverflow.com/questions/66731036/unable-to-import-pyodbc-on-apple-silicon-symbol-not-found-sqlallochandle ## v1.4.0 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fb39952f..eca250d3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ pyenv activate dbt-synapse Install the development dependencies and pre-commit and get information about possible make commands: ```shell -make dev # if Windows, remove `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt +make dev # for Mac users, add `pyodbc==4.0.39 --no-binary :all:` in dev_requirements.txt before running `make dev` make help ``` diff --git a/dev_requirements.txt b/dev_requirements.txt index 06071e8d..7e77f77b 100644 --- a/dev_requirements.txt +++ b/dev_requirements.txt @@ -5,7 +5,6 @@ pre-commit==2.21.0;python_version<"3.8" pre-commit==3.3.1;python_version>="3.8" pytest-dotenv==0.5.2 dbt-tests-adapter~=1.4.9 -pyodbc==4.0.39 --no-binary :all: # if Windows, remove aiohttp==3.8.3 azure-mgmt-synapse==2.0.0 flaky==3.7.0