Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded references to fabric__create_table_as #183

Closed
ms32035 opened this issue May 26, 2024 · 2 comments
Closed

Hard coded references to fabric__create_table_as #183

ms32035 opened this issue May 26, 2024 · 2 comments

Comments

@ms32035
Copy link

ms32035 commented May 26, 2024

For example here:
https://github.com/microsoft/dbt-fabric/blob/main/dbt/include/fabric/macros/materializations/models/incremental/incremental.sql#L34
we should be doing adapter.create_table_as. The current code breaks things downstream in dbt-sqlserver

@prdpsvs
Copy link
Collaborator

prdpsvs commented May 27, 2024

@ms32035 , this being handled in dbt-fabric 1.8.6 PR #178
I am fixing such downstream issues that might happen in dbt-synapse. Do add more if you find any.
I will release the minor patch tomorrow.

@prdpsvs
Copy link
Collaborator

prdpsvs commented May 31, 2024

@ms32035 , hard coded references are removed except for tests helper. Synapse adapter will have its own version of tests helper.
Please review v1.8.6 release and let me know. I am closing this issue at this time but feel free to share any other hard coded references.

@prdpsvs prdpsvs closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants