Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior of group "exclude" options #916

Open
ecraig12345 opened this issue Sep 1, 2023 · 0 comments
Open

Fix behavior of group "exclude" options #916

ecraig12345 opened this issue Sep 1, 2023 · 0 comments
Labels
breaking change bug Something isn't working in next

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Sep 1, 2023 •
edited
Loading

Currently the exclude option for ChangelogGroupOptions and VersionGroupOptions (and isPathIncluded internally) expects negated patterns: e.g. if you want to exclude packages/foo, you must specify exclude as !packages/foo.

This is a counterintuitive design which does not match other tools, and should be updated in a major version to remove the negation requirement.

Closed PR: #656
@ecraig12345 ecraig12345 added bug Something isn't working breaking change labels Sep 1, 2023
@ecraig12345 ecraig12345 mentioned this issue Sep 1, 2023
Merged
ecraig12345 added a commit that referenced this issue Nov 24, 2024
@ecraig12345
[breaking] Fix behavior of VersionGroupOptions.exclude (see #916)
35dc015
ecraig12345 added a commit that referenced this issue Nov 25, 2024
@ecraig12345
[breaking] Fix behavior of VersionGroupOptions.exclude (see #916)
6be3f38
ecraig12345 added a commit that referenced this issue Nov 25, 2024
@ecraig12345
[breaking] Fix behavior of VersionGroupOptions.exclude (see #916)
05966c3
ecraig12345 added a commit that referenced this issue Nov 25, 2024
@ecraig12345
[breaking] Fix behavior of VersionGroupOptions.exclude (see #916)
cd4d09e
ecraig12345 added a commit that referenced this issue Nov 26, 2024
@ecraig12345
[breaking] Fix behavior of VersionGroupOptions.exclude (see #916)
3f82b99
ecraig12345 added a commit that referenced this issue Nov 26, 2024
@ecraig12345
[breaking] Fix behavior of VersionGroupOptions.exclude (see #916)
b75f433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug Something isn't working in next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ecraig12345