Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the TLS 1.2 protocol is supported #443

Open
variableresistor opened this issue Jan 8, 2025 · 0 comments · May be fixed by #444
Open

Only the TLS 1.2 protocol is supported #443

variableresistor opened this issue Jan 8, 2025 · 0 comments · May be fixed by #444
Labels
enhancement An issue or pull request introducing new functionality to the project. triage needed An issue that needs to be reviewed by a member of the team.

Comments

@variableresistor
Copy link
Contributor

Feature Idea Summary

PowerShell Core supports the faster TLS 1.3 protocol, but the module forces it to use 1.2.

Feature Idea Additional Details

In the GitHubCore.ps1 file:

[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12

Requested Assignment

Don't care. I can do it if the PR doesn't take too long. Just change the above code to:

if ($PSVersionTable.PSVersion -lt 7.0.0)
{
    [Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12
}

and in the finally block:

if ($PSVersionTable.PSVersion -lt 7.0.0)
{
    [Net.ServicePointManager]::SecurityProtocol = $originalSecurityProtocol
}

PowerShell 6 isn't supported anymore, so anything less than 7 should use TLS 1.2.

Operating System

All

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.6
PSEdition                      Core
GitCommitId                    7.4.6
OS                             Microsoft Windows 10.0.19045
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Module Version

Running: 0.17.0
Installed: 0.17.0

@variableresistor variableresistor added enhancement An issue or pull request introducing new functionality to the project. triage needed An issue that needs to be reviewed by a member of the team. labels Jan 8, 2025
@variableresistor variableresistor linked a pull request Jan 8, 2025 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An issue or pull request introducing new functionality to the project. triage needed An issue that needs to be reviewed by a member of the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant