Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIR sample rate ignored? #168

Open
blaine-fs opened this issue Jul 31, 2023 · 0 comments
Open

RIR sample rate ignored? #168

blaine-fs opened this issue Jul 31, 2023 · 0 comments

Comments

@blaine-fs
Copy link

blaine-fs commented Jul 31, 2023

I noticed that fs_rir does not seem to be used after it's read from the RIR file.
https://github.com/microsoft/DNS-Challenge/blob/master/noisyspeech_synthesizer_singleprocess.py#L178

Should the RIR be resampled to params['fs'], as the audio has been? Or is this handled elsewhere?

This may not have been an issue with the old 16 kHz RIR's, as they incidentally matched the target sample rate. But I noticed the new data now has 48 kHz RIRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant