Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sampling Percentage to Accept 0 as Valid #1337

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Update Sampling Percentage to Accept 0 as Valid #1337

merged 7 commits into from
Jun 7, 2024

Conversation

JacksonWeber
Copy link
Contributor

@JacksonWeber JacksonWeber commented May 30, 2024 •
edited
Loading

  • Previously setting the sampling percentage as 0 would actually set sampling to 1 as 0 is falsy and would revert to the default value of the sampling percentage.

Resolves #1336

@JacksonWeber JacksonWeber requested a review from hectorhdzg May 30, 2024 18:02
hectorhdzg
hectorhdzg approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit c98e546 into microsoft:main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Disable Logging by Setting samplingRate to Zero
2 participants
@JacksonWeber @hectorhdzg