Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berkeley: Incorporate refscan graphs into schema documentation #2188

Closed
eecavanna opened this issue Sep 25, 2024 · 8 comments
Closed

berkeley: Incorporate refscan graphs into schema documentation #2188

eecavanna opened this issue Sep 25, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request X SMALL Less than 8 hours, less than 1 day

Comments

@eecavanna
Copy link
Collaborator

eecavanna commented Sep 25, 2024

Idea: Use GitHub Actions to install refscan from PyPI, run it on the latest schema, and store the resulting HTML file in the right place in the schema docs so that it appears on the deployed schema docs website.

Emphasis: This does not involve adding any more "derived files" to the repo. The docs are built by GHA.

Limitation: refscan only works with the Berkeley schema (due to refscan's dependence upon the type field, which is only "reliable" in the Berkeley schema).

During today's NMDC sync, people seemed to me to want this to be a public-facing diagram and some of them seemed to me to be in favor of it living in the schema repo (in this case, it would start out in the berkeley-schema-fy24 repo and only appear in the nmdc-schema repo once the fork gets merged into the base). Needs buy-in from @turbomam, specifically, as lead maintainer of the repo.

Currently, graphs are hosted at this improvised URL: https://portal.nersc.gov/project/m3408/refscan/

@eecavanna eecavanna added documentation Improvements or additions to documentation enhancement New feature or request X SMALL Less than 8 hours, less than 1 day labels Sep 25, 2024
@eecavanna eecavanna self-assigned this Sep 25, 2024
@turbomam
Copy link
Member

I support adding the refgraphs to the nmdc-schema documentation. I will probably have some suggestions for brief documentation that could go along with it.

@eecavanna
Copy link
Collaborator Author

I support adding the refgraphs to the nmdc-schema documentation.

Thanks, @turbomam. I'll try to make this happen next sprint.

I will probably have some suggestions for brief documentation that could go along with it.

Sounds good to me.

@eecavanna
Copy link
Collaborator Author

I've prototyped this in berkeley-schema-fy24 PR microbiomedata#265.

@eecavanna eecavanna moved this from In Progress to In Review in 2024 - Sprint 46 - September 23 - October 4, 2024 Oct 3, 2024
@eecavanna eecavanna moved this from In Progress to In Review in Non-Squad Board Oct 3, 2024
@ssarrafan
Copy link
Collaborator

@turbomam @sujaypatil96 can you provide feedback on PR microbiomedata#265 please?

@eecavanna I'm guessing this is on hold till after the Berkeley rollout correct? Can we move this to next sprint?

@eecavanna
Copy link
Collaborator Author

Yes, next sprint, please. We did decide to hold off on merging this until after the Berkeley Schema Roll Out (even if the PR has been reviewed/approved before then).

@eecavanna
Copy link
Collaborator Author

This has been implemented in #2198 and I am ready for it to be merged in.

@eecavanna
Copy link
Collaborator Author

Part of this has been re-implemented (more granularly) in PR #2240.

@eecavanna
Copy link
Collaborator Author

Closing this ticket in favor of the following two, newer, more narrowly-scoped tickets:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request X SMALL Less than 8 hours, less than 1 day
Projects
Status: Done
3 participants