Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the sample attributes, when adding a value for "tissue growth media" I see a text box, but the example shows me a URL - I am not sure which to provide #188

Closed
sierra-moxon opened this issue Sep 25, 2024 · 4 comments
Labels
beta-feedback Related to feedback received from beta testers bug Something isn't working

Comments

@sierra-moxon
Copy link
Member

sierra-moxon commented Sep 25, 2024

Bug summary

when adding data for "tissue growth media" I see a text box, but the example shows me a URL - I am not sure which to provide

Bug details

The tissue culture growth media input field is a text box. Because of this, I expect I should be able to describe in words what my tissue culture growth media is (tangential question - should this actually be a controlled vocabulary of terms instead of free text?) I started entering text, but then, when consulting the example, I saw a URL -- does that mean it should be the URL for a paper that describes my materials and methods?

Steps to reproduce

  1. Launch app
  2. create a study
  3. create a sample
  4. fill in the tissue culture growth media field

Anything else?

No response

App version

No response

Device type

Apple

Operating system version

iOS 17.6.1

@sierra-moxon sierra-moxon added the bug Something isn't working label Sep 25, 2024
@sierra-moxon sierra-moxon changed the title when adding data for "tissue growth media" I see a text box, but the example shows me a URL - I am not sure which to provide In the sample attributes, when adding a value for "tissue growth media" I see a text box, but the example shows me a URL - I am not sure which to provide Sep 25, 2024
@mslarae13
Copy link

This is a broader submission / schema issue too.
It's all a text box really. So if it's a URL, should we have a different formatted box?

Though, I can say, from getting metadata from users. They almost ALWAYS provide text. Not a URL.

@mslarae13
Copy link

@pkalita-lbl pkalita-lbl added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Nov 11, 2024
@pkalita-lbl
Copy link
Collaborator

Yeah, my understanding is that we're talking about this slot: https://microbiomedata.github.io/submission-schema/tiss_cult_growth_med/

The description of the slot says "Description of plant tissue culture growth media used" which is fairly generic. The example for the slot is https://link.springer.com/content/pdf/10.1007/BF02796489.pdf. I believe that led to the confusion about what should be actually entered into the text box: a textual description? a URL where a description of the method can be found? In reality I believe either of those are acceptable. So maybe the answer here is that the slot's description should be expanded to explicitly state what type(s) of thing(s) we're looking for.

@pkalita-lbl
Copy link
Collaborator

Since this is a schema issue I'm closing this issue in favor of an issue in the nmdc-schema repo

Duplicate of microbiomedata/nmdc-schema#2267

@pkalita-lbl pkalita-lbl closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-feedback Related to feedback received from beta testers bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants