You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found some potential issue in Dragonfly Plate Reverb source code. Is it a bug, or just some unused code?
In dragonfly-plate-reverb/DSP.cpp, DragonflyReverbDSP::run(), we set model to different value.
if (algorithm == ALGORITHM_NREV) {
model = &nrev;
} else if (algorithm == ALGORITHM_NREV_B) {
model = &nrevb;
}
...
Then call model->processreplace(). For nrev and nrevb, they both use FV3_(nrev)::processreplace(). NRevB::processloop2() is never called.
Should we call processloop2() here?
The text was updated successfully, but these errors were encountered:
Hi there,
I found some potential issue in Dragonfly Plate Reverb source code. Is it a bug, or just some unused code?
In dragonfly-plate-reverb/DSP.cpp, DragonflyReverbDSP::run(), we set
model
to different value.Then call
model->processreplace()
. Fornrev
andnrevb
, they both useFV3_(nrev)::processreplace()
.NRevB::processloop2()
is never called.Should we call
processloop2()
here?The text was updated successfully, but these errors were encountered: