Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons missing a viewBox field #39

Open
BBaoVanC opened this issue May 1, 2022 · 2 comments
Open

Some icons missing a viewBox field #39

BBaoVanC opened this issue May 1, 2022 · 2 comments

Comments

@BBaoVanC
Copy link

BBaoVanC commented May 1, 2022

I'm trying to use some CSS to modify my icons to be an exact size. It works with most icons, but a few don't have a viewBox parameter, and with those it doesn't work. Should this parameter be added to all of the SVGs?

@michaelampr
Copy link
Owner

Hey @BBaoVanC, thanks for reporting this issue.
Yup, all the 940 icons should already have a viewBox prop. Can you tell me which ones you have trouble with?

@BBaoVanC
Copy link
Author

BBaoVanC commented May 5, 2022

According to a quick search, it looks like these icons are missing a viewBox parameter:

$ grep -L viewBox -r icons/
table-left-header.svg
dice.svg
superscript.svg
dices-f.svg
browse.svg
flashlight-on.svg
telegram.svg
orientaton.svg
dices.svg
code.svg
accessibility.svg
select-all.svg
picture-edit.svg
table-right-header.svg
ltr.svg
text.svg
table-row-above.svg
paragraph.svg
tab.svg
code-sample.svg
subscript.svg
table-cell.svg
intersection.svg
dice-f.svg
table-delete.svg
dribbble.svg
table-cell-merge.svg
page-break.svg
union.svg
table-row-after.svg
gamma.svg
table-col-before.svg
template.svg
star-half-f.svg
table.svg
differenciation.svg
discord.svg
subtraction.svg
rtl.svg
spell-check.svg
table-top-header.svg
table-col-after.svg
quote.svg
character.svg
unlink.svg

I discovered this issue when I was trying to add share icons, and the Telegram one (it's in the list above) wasn't behaving the same as the others when resizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants