Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access method to null when no url #8

Open
michael-conway opened this issue Sep 30, 2019 · 0 comments
Open

access method to null when no url #8

michael-conway opened this issue Sep 30, 2019 · 0 comments
Assignees

Comments

@michael-conway
Copy link
Owner

just have one suggestion for the data presented under the "access_methods" property, particularly for the access method where type == "https". Right now, under the "access_url" property, you have "access_url": {"url": "", "headers": []}

Would it be easier to have "access_url": null, or simply leave out the property altogether? The reason I mention this is that it's impossible to get any data from access_url (as the url is blank), so clients may get confused thinking they can download via the access_url, when really they have to use the access_id

The specification only requires either access_url or access_id to be included, not both. This issue currently doesn't affect my client, as the client checks first for access id before looking at access url. But other clients may get confused when they see the "access_url" property, only to find that the "url" field is blank.

@michael-conway michael-conway self-assigned this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant