New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Storybook to v7 #977

Closed

MI6-255 opened this issue Aug 7, 2023 · 1 comment

Assignees

Labels

dx

Milestone

Contributor

MI6-255 commented Aug 7, 2023

Summary

Upgrade Storybook from version 6 to version 7 and implement necessary structural changes.

💬 Description

Currently, our codebase utilises Storybook version 6 for component development and testing. To keep up with the latest features and improvements, we need to upgrade Storybook to version 7. This upgrade requires making structural changes to adapt to the new version's APIs and convention. More information can be found here: https://storybook.js.org/docs/react/migration-guide

💰 Use value

Ensures our component development environment remains up-to-date and utilise the latest features.

MI6-255 added the dx label

MI6-255 added this to the V2.x milestone

MI6-255 added this to Intelligence Community Design System

MI6-255 moved this to In Refinement in Intelligence Community Design System

ASM995 moved this from In Refinement to Ready for dev in Intelligence Community Design System

GCHQ-Developer-530 self-assigned this

GCHQ-Developer-530 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System

GCHQ-Developer-530 added a commit that referenced this issue


          chore(react): upgrade storybook to v7

10ec039

Upgrade storybook to v7 and update mdx files to match mdx2 style

. #977

GCHQ-Developer-530 added a commit that referenced this issue


          chore(web-components): upgrade storybook to v7

c897b2e

Upgrade storybook to v7 and update mdx files to match mdx2 style

. #977

GCHQ-Developer-530 added a commit that referenced this issue


          chore(react): upgrade storybook to v7

49b494e

Upgrade storybook to v7 and update mdx files to match mdx2 style

. #977

GCHQ-Developer-530 added a commit that referenced this issue


          chore(web-components): upgrade storybook to v7

3bea4c9

Upgrade storybook to v7 and update mdx files to match mdx2 style

. #977

GCHQ-Developer-530 added a commit that referenced this issue


          chore(web-components): upgrade storybook to v7

186cd68

Upgrade storybook to v7 and update mdx files to match mdx2 style

. #977

Contributor

GCHQ-Developer-530 commented Sep 20, 2023

This is currently blocked.

Work has been completed on branch 977-upgrade-to-storybook-7, however there is an issue with loki tests and version 7 of storybook.

Once this PR has been merged, we should be able to pick up this work again.

GCHQ-Developer-530 moved this from Dev In Progress to Ready for dev in Intelligence Community Design System

GCHQ-Developer-530 removed their assignment

ASM995 modified the milestones: V2.x, PI 5 V.2

GCHQ-Developer-112 assigned zxh722

zxh722 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System

zxh722 mentioned this issue

977 upgrade storybook to v7 #1347

Merged

21 tasks

zxh722 added a commit that referenced this issue


          feat(web-components): fix styling for ic-top-navigation.tsx

5665a43

. #977

zxh722 moved this from Dev In Progress to In Review in Intelligence Community Design System

zxh722 added a commit that referenced this issue


          feat(web-components): update web components storybook to v7.6.7

4a45bc0

Http-server runs to enable the storybook-static folder to interact with the loki tests. MDX files updated to the new MDX2 format.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web components storybook to v7.6.7

04652f3

Http-server runs to enable the storybook-static folder to interact with the loki tests. MDX files updated to the new MDX2 format.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

7aff570

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

GCHQ-Developer-112 added a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

GCHQ-Developer-112 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

GCHQ-Developer-112 added a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

5c79039

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

GCHQ-Developer-112 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

8995c3e

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

GCHQ-Developer-112 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

92007cf

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

825f720

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

38f85d2

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

191966b

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

fefd851

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

GCHQ-Developer-112 added a commit that referenced this issue


          fix(web-components): add placement of tooltips on "Go to" buttons to …

d392966

…the top

Move placement of the tooltips on the "Go to" buttons to prevent double scrolling on ic-data-table.
Update snapshot tests

. #977

GCHQ-Developer-112 added a commit that referenced this issue


          feat(canary-web-components): conditionally change the placement of th…

…e tooltip on truncated text

ensure that when the tooltip truncation pattern is chosen and text has been truncated, the tooltip
does not cause a double scroll on ic-data-table. Update the positioning of the tooltip in the
pagination bar to prevent a double scroll. Prettier fixes

. #977

ASM995 modified the milestones: PI 5 V.2, PI 6 V.2

zxh722 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

df3cc92

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

848e710

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

ad9242 mentioned this issue

Upgrade storybook to v7 in canary packages #1431

Closed

ad9242 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

8b89618

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

ad9242 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

423eaac

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

ad9242 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

b4607b2

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

e17e2b5

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

a377d7b

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

6ed69dd

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

d865f83

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

efbedc1

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

b6f10d0

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 added a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

386d43b

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

GCHQ-Developer-299 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

c4720a9

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

GCHQ-Developer-299 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

f9eddf7

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

GCHQ-Developer-299 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

2b78e63

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

GCHQ-Developer-299 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

ebf6038

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

zxh722 moved this from In Review to Done in Intelligence Community Design System

ad9242 mentioned this issue

review audit exceptions after storybook upgrade #1453

Closed

GCHQ-Developer-112 closed this as completed

GCHQ-Developer-299 pushed a commit that referenced this issue


          feat(react): update react storybook to v7.6.7

d6df566

Install storybook v7.6.7, update scripts, add new Storybook plugin for GitHub-flavoured markdown,
fixes to stories

. #977

GCHQ-Developer-299 pushed a commit that referenced this issue


          feat(web-components): update web-components storybook to v7.6.7

bb53370

Storybook-static folder is now being served on a http-server to interact with Loki, update MDX files
from MDX1 to MDX2. Prettier fixes to files.

. #977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment