Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more functionality to this fork against vlaci/openconnect-sso (open PR at vlaci#76) to enable custom user scripts and screenshots on failures.
Thanks @YoungElPaso for suggesting the enhancements.
From a comment:
Changes:
Allow a custom javascript script to be passed which will override the
auto_fill_rules
via the CLI argument--override-script
or config propertyoverride_script
. The script will be expanded with environment variables includingUSERNAME
andPASSWORD
to allow generic script creation. An example of a working custom script (same functionality as the default rules) is available atexample/defaultRules.js
Screenshot failures using selenium during an exchange when in
headless
mode. Screenshots will be saved to the current working directory.Allow specifying a timeout value for waiting on the SSO exchange in the browser using the CLI argument
--authenticate_timeout
or config propertyauthenticate_timeout
(value in seconds - defaults to10
).Example: