Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods suggestions, Latitudes and longitudes, Silent and Volume settings, World cities, and New options #80

Open
TorCzaf opened this issue Jul 29, 2023 · 14 comments
Labels
enhancement New feature or request

Comments

@TorCzaf
Copy link

TorCzaf commented Jul 29, 2023

Hi, I have 9 ideas:

1#can you add some suggestions in the app in case some people don't know which calculation method to choose.

Like in this app here you can see it mentions the appropriate calculation method for each region
App name: "Everyday muslim"
Screenshot_20230728-230153


The 8 ideas below are from  "Salatuk" app
Note: This app has many many calculation methods I will send them email and see if I can get the parameters from them.

2#Add latitude and longitude numbers for each city in "search" window this could be useful for those who have curiosity or want to know latitudes and longitudes of other cities while scrolling.

Like in "Salatuk" app
Screenshot_20230728-231415_Salatuk

3#Add silent settings for the app like these below
Screenshot_20230729-004357_Salatuk

4#Add for each prayer an option to make its adhan
Enabled during silent mode instead of (Bypass "do not disturb") option.
Also Same thing for reminders please, I mean each reminder should have such an option

5#Add another option for each prayer so the phone vibrates when prayer time comes instead of doing adhan

Like that:
Screenshot_20230729-180728_Salatuk

6#Add an option to stop Adhan and reminders by  turning the device screen face down.

By the way, when I want stop adhan, sometimes I press power button by mistake and that causes volume button to not stop adhan unless I press power button again to press on volume button again.

7#Volume Level settings like these
Screenshot_20230729-010149_Salatuk

8#Add world cities page like this
As can you see it has top 3 famous and important islamic cities as well as their prayer times, and you can also add more cities or remove some
Screenshot_20230729-144627_Salatuk

9#Add persistent notification settings in "Widget Settings" like these
Screenshot_20230729-161752_Salatuk
It would be better if you can allow the user to determine minutes by himself


Thank you.

@TorCzaf TorCzaf added the enhancement New feature or request label Jul 29, 2023
@TorCzaf
Copy link
Author

TorCzaf commented Jul 29, 2023

I just got another new idea and I think it is important for those who have weakness in vision or for old people.
I don't know how to say it or explain it but please make the app allow users to make screen (words and numbers) bigger by their fingers to see prayer times in "Monthly view" and main screen of the app for example.

@meypod
Copy link
Owner

meypod commented Jul 29, 2023

1# Suggested regions of "Everyday muslim" doesn't make sense, for example Turks in Germany may use Diyanet and ...

2# Latitude and longitude are already shown after you choose location, I don't see a reason to show users the location coordinates while scrolling. It clutters the UI while providing next to no benefit

3# sounds useful

4# sounds useful too
5# sounds okay.

6# sounds like too much work with little in return. sadly I do not see why this would be useful

7# Al-Azan doesn't use media or ring audio, it uses alarm audio, since it's actually an alarm.

8# what's the need for such list? it doesn't seem useful either

9# it does not make sense to automatically show/hide the notification widget only around prayer times. and there's upcoming adhan notification if you want to be aware that there's an upcoming adhan alarm. overall doesn't sound useful to me

10# old people like my parents use OS level font size adjustment, so they usually have larger texts everywhere. the app does not force a fixed font size and allows fonts to grow. they have their font size set to maximum and have no problem seeing the home screen. monthly view is exceptionally small, because the times would cut off on normal phones.


so from these, I'll try to implement 3#, 4#, 5# on my free time :)

@meypod
Copy link
Owner

meypod commented Jul 29, 2023

about volume button bug, I'm not sure how to fix it right now, because there's not a straightforward way in android to listen for the button press. maybe I'll look at it later

@TorCzaf
Copy link
Author

TorCzaf commented Jul 30, 2023

1# How about you and I do our own research and I may try to do my best for that In-shaa-Allah

For example we currently don't have angles for Korea but I have mentioned before that prayer times in Korea depend on Muslim World League now we know that Muslim World League method should be for korea
And this below should be a proof that they depend on Muslim World League method in Korea
Note:  I don't know which one "South korea or North or both"

https://www.koreaislam.org/en/prayer-times/
Also I found Korean prayer times...they are based on Muslim World League
https://www-koreaislam-org.translate.goog/en/prayer-times/?uid=31&mod=document&_x_tr_sl=auto&_x_tr_tl=en&_x_tr_hl=en-US&_x_tr_pto=wapp

Another example , we currently don't know the angles for New Zealand but
Federation of Islamic Associations of New Zealand
https://fianz.com/prayer-times/
Mention that They use Muslim World League method on their website
So This should be a proof that Muslim World League method should be for New Zealand

Third Example: In Brunei they use Kementrian Hal Ehwal Ugama method

And so on....

2# May be useful for those who want to do fast comparison in terms of latitude and longitude between cities instead of typing city's name and clicking on it?
What do you mean by "clutter"?
You mean mess?

6# Might be useful for avoiding volume button bug in case there is no solution for it?
I personally would use it instead of using volume buttons due to that bug
Or it could be useful for those who have their buttons ruined or malfunctioning

7# ah yes...right.

8# This could be useful for those who will have somebody or relatives outside to do umrah or hajj or outside in somewhere else and want to know their prayer times or want to remind them with prayers or maybe with other religious events or non-religious or want to check on their times for other things instead of switching between countries and calculation methods manually every period of time in the app or searching on Google (which requires internet).
I have people outside and I use Google to know what time is in their region.
It would be indeed awesome if you add this valuable feature.

Of course this idea may depend on appropriate automatic calculation method system for the cities just like "Salatuk" app does...for that you and I may need to do our research first.  And it also may depend on appropriate independent automatic time system for the shown cities I mean "Salatuk" app shows the current time and correct prayer times for world cities without the need to change phone timezone.

I know that you have said before that adding independent automatic time system would increase complexity of time handling but I don't think that this would  increase complexity as long as World cities feature should has a separate page and has automatic time system that the user shouldn't interfere with. All what the user will do is just seeing prayer times and current times for cities like in "Salatuk" app.

9# Ah yes I forgot there is upcoming adhan notification.

it does not make sense to automatically show/hide the notification widget only around prayer times

Notifications that are always on can drain phone batteries (maybe) especially for those whose phones suffer from power leaks.
It would be better to allow people decide by themselves the period they need :)

As for upcoming adhan notification this should be useful for those who have notifications always displayed.

10# May Allah protect our families. Amen.
I am not talking about OS level font size adjustment, nor am I talking about fixed fonts. I am talking about that the user should move his fingers on the screen to see what is small as big in size especially for "Monthly view".
Just like moving your Index and thumb towards each other or opposite each other (closing and opening both fingers) on your android browser screen or when viewing pictures on your phone.
I think this is a simple useful feature your app should has.

@meypod
Copy link
Owner

meypod commented Jul 30, 2023

1# What I mean is different groups use different methods no matter the country they are living in, for example Turks even when living in Germany may not use Muslim world league but instead may use Diyanet method, Shias may use Geophysic of Tehran even when living in Australia

2# Well doesn't seem very useful to compare longitude and latitude fast, yeah I mean mess, it would make scrolling through names of cities harder for most of people who don't want to check latitude and longitude

6# I'll look into the bug later

8# Sounds like a very niche use case so not planned. I have added favorite locations which allows someone to switch between locations easily, but it's not released yet, but it's available in latest rc.

9# I don't think notification widget drain much battery, But if someone doesn't want notification widget then they can turn off notification widget and just use upcoming adhan reminder which only appears at adjustable time before adhan or reminders. the widget does not actively consume battery to calculate anything. unless you have countdown enabled but even then it's usage is minimal.

10# I got what you mean. It's hard to implement and pinches can happen unintentionally, so it's not planned

@TorCzaf
Copy link
Author

TorCzaf commented Jul 31, 2023

1# You mean that as a problem in "Everyday Muslim" app, right?
For that I suggested that you and I should find out by ourselves for each region its appropriate method.  And I gave you examples.

2# OK.

8# When you say "niche", you mean personal or private or something like that?
How about you add an option to save calculation method  for favorite locations?

9#

they can turn off notification widget and just use upcoming adhan reminder which only appears at adjustable time before adhan or reminders.

Can you make upcoming alarm notification has these features "city name and countdown" in case people turn off notification widget?
Screenshot_20230731-112521_One UI Home

And also please add city name for notification widget too. I suggest adding this feature for notification widget and upcoming alarm notification in case people choose wrong city in app settings and don't realize that or forget to change it. I mean the notifications should remind people of the chosen city.

And make minutes adjustable please because Currently users can only switch between minutes.

10# I may look for contributors.
Or how about you add an option to increase font size in your app?
I don't think it is a great idea that people should increase font size using phone settings just for one app because that would affect the other apps.
There are no settings in the OS to adjust font size for specific app.
Screenshot_20230730-211251_Settings

@meypod
Copy link
Owner

meypod commented Aug 1, 2023

1# No I mean geographical regions cannot be assigned to methods

8# by niche I mean it's use case is very limited

9# widget doesn't have space to add city name, I may later add a notification widget that only shows upcoming prayer and have countdown, but since the app is not native it takes extra work, so not a priority.

And make minutes adjustable please because Currently users can only switch between minutes.

Maybe later, I don't thinks It's a very useful idea either

10# my point is, if they cannot see, they need to increase font size across all apps anyway. but I'll maybe add this as an option as well. this is also low priority.

@TorCzaf
Copy link
Author

TorCzaf commented Aug 1, 2023

1# You mean like If someone from USA and lives in Saudi arabia, he should choose ISNA method?

Or if someone from Russia and lives in USA, he should choose Spiritual administration of Muslims of Russia method? Like that?

Or you mean people may choose what they think is suitable for them from their perspective view?

9#

widget doesn't have space to add city name

I apologize for any inconvenience but What about left and right bottom? Or the top?
Screenshot_20230802-021821_Gallery

since the app is not native it takes extra work, so not a priority.

I appreciate your effort...take your time.
I only give suggestions for the future.

@meypod
Copy link
Owner

meypod commented Aug 4, 2023

1# what I mean is you cannot recommend a method based on geographic location in any way, there is no correlation. so each individual should do their own research

9# bottom corners are only available when countdown visible, so it's not useful
top middle is also very narrow, and most of city names are not small

@TorCzaf
Copy link
Author

TorCzaf commented Aug 9, 2023

@meypod May I talk to you privately please via an email address, if you don't mind?

@meypod
Copy link
Owner

meypod commented Aug 10, 2023

@TorCzaf
[email protected]
or via matrix: @meypod:matrix.org

@GoodM4ven
Copy link

GoodM4ven commented Oct 30, 2023

  • Putting phones to preferably do-not-disturb or silent mode after athan by a certain amount of minutes should be top-priority in my opinion.
  • May I also suggest having either a switch to disabling the secondary calendar in the widget settings, or having it disabling the secondary calendar everywhere in display settings.
  • Also, it might be great if there was an option to disabling the "qada" feature altogether, and effectively hiding the plus-sign from the top bar when the app is open.

-Much obliged for the great work so far! ✨

@meypod
Copy link
Owner

meypod commented Oct 30, 2023

Hi
this project is made in my free time, surely I will be adding features over time, but I can't give an estimate when it will be added

  • May I also suggest having either a switch to disabling the secondary calendar in the widget settings, or having it disabling the secondary calendar everywhere in display settings.
  • Also, it might be great if there was an option to disabling the "qada" feature altogether, and effectively hiding the plus-sign from the top bar when the app is open.

why ? how is it causing problem that you want to hide it ?

@GoodM4ven
Copy link

this project is made in my free time, surely I will be adding features over time, but I can't give an estimate when it will be added

Understood.

why?

I don't think customization or personalization needs a specific reasoning behind it. However, here are some thoughts:

  • The secondary calendar being displayed on the widget means having multiple Gregorian calendars in most cases, either displayed by the system or by another widget that's designed to solely function as a calendar; plus this app's. And this could obviously be as annoying as having the time showing in 3 or 4 places when the phone is open, for instance!

  • As for the "qada" feature, even though I'm not familiar of the Islamic concept behind it, I think having a plus-sign icon in the UI indicates something about adding reminders or time-trackers of sort, given the rest of the main app page's structure, that is... -Just a UI observation, nothing serious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants