Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fanout and some other utilities in metrics-util is not Sync #533

Open
ChieloNewctle opened this issue Oct 14, 2024 · 1 comment
Open

Fanout and some other utilities in metrics-util is not Sync #533

ChieloNewctle opened this issue Oct 14, 2024 · 1 comment
Labels
C-util Component: utility classes and helpers. E-intermediate Effort: intermediate. T-ergonomics Type: ergonomics. T-regression Type: regression.

Comments

@ChieloNewctle
Copy link

ChieloNewctle commented Oct 14, 2024 •
edited
Loading

metrics::set_global_recorder requires Sync now from the version 0.18.0.
However, metrics-util still uses Box<dyn Recorder> for some utilities like Fanout, which is not Sync.

Maybe some new Sync types can be introduced for global recorders?

Thanks.
@tobz tobz added C-util Component: utility classes and helpers. E-intermediate Effort: intermediate. T-regression Type: regression. T-ergonomics Type: ergonomics. labels Oct 14, 2024
@tobz
Copy link
Member

tobz commented Oct 14, 2024

👋🏻

Yeah, darn... that is an unfortunate regression based on our change to set_global_recorder. 🤦🏻 I'll have to think a little about this.

@tobz tobz mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-util Component: utility classes and helpers. E-intermediate Effort: intermediate. T-ergonomics Type: ergonomics. T-regression Type: regression.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobz @ChieloNewctle