Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose way to configure RollingSummary #430

Closed
rukai opened this issue Dec 20, 2023 · 4 comments
Closed

Expose way to configure RollingSummary #430

rukai opened this issue Dec 20, 2023 · 4 comments
Labels
C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-enhancement Type: enhancement. T-request Type: request.

Comments

@rukai
Copy link
Contributor

rukai commented Dec 20, 2023

RollingSummary was internally introduced here #306
But there is currently no way for the user to configure how long data is held onto for high level users of metrics/metrics-exporter-prometheus
@tobz tobz added C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-enhancement Type: enhancement. T-request Type: request. labels Dec 23, 2023
@tobz
Copy link
Member

tobz commented Dec 23, 2023

Yeah, this is a reasonable request. I would accept a PR adding methods to the builder that allow configuring the bucket width and count.

@lilyball
Copy link

It looks like this was already done in #444

@tobz
Copy link
Member

tobz commented Mar 16, 2024

Yep, just awaiting a release of metrics-exporter-prometheus, which should hopefully be doable somewhere between today and the next seven days. I've been queueing up a lot of changes to bundle together.

@tobz tobz added the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Mar 16, 2024
@tobz
Copy link
Member

tobz commented Mar 16, 2024

Released in [email protected].

@tobz tobz closed this as completed Mar 16, 2024
@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-exporter Component: exporters such as Prometheus, TCP, etc. E-simple Effort: simple. T-enhancement Type: enhancement. T-request Type: request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lilyball @tobz @rukai