Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serializing and deserializing metrics_util::Summary #410

Open
seekstar opened this issue Nov 11, 2023 · 1 comment
Open

Support serializing and deserializing metrics_util::Summary #410

seekstar opened this issue Nov 11, 2023 · 1 comment
Labels
C-util Component: utility classes and helpers. E-simple Effort: simple. T-enhancement Type: enhancement.

Comments

@seekstar
Copy link

seekstar commented Nov 11, 2023

I use metrics_util::Summary to measure quantiles of latencies. The latency files are too large, so I usually only save the calculated quantiles (0.1, 0.2, ..., 0.9, 0.99, 0.999, etc). However, the problem is that sometimes I want to know latencies at other quantiles (e.g., 0.91, 0.92, ..., 0.98), but the original latency files are not saved. This problem can be solved perfectly if metrics_util::Summary can be serialized and deserialized, so that I can save the metrics_util::Summary instead of large latency files.

@tobz tobz added C-util Component: utility classes and helpers. E-simple Effort: simple. T-enhancement Type: enhancement. labels Nov 12, 2023
@tobz
Copy link
Member

tobz commented Nov 12, 2023

It seems like this should be technically possible: sketches-ddsketch supports implementing Serialize/Deserialize for DDSketch, gated behind a feature flag. We could do the same thing -- expose an optional feature flag -- which would in turn activate the feature flag in sketches-ddsketch.

Not sure when I'll be able to get to this, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-util Component: utility classes and helpers. E-simple Effort: simple. T-enhancement Type: enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants