reitit.coercion.malli - invalid keys for :responses are accepted

[vemv]

I had been mistakenly using the following:

:responses {:200 {:body SomeMalliSchema}
            :500 {:body SomeOtherSchema}}

Where the mistake was using :200 instead of 200.

To make matters more confusing, :200 does work for Swagger schema emission. It's just coercion that expects strictly a 200 and ignores :200. It also happily accepts other invalid keys like :foo, 'bar, [1 2 3], etc.

I'd appreciate a stricter validation here - especially as it's a fairly crititical part of any Reitit-based system.

Thanks - V

[ikitommi]

Agree, PR most welcome on this.

[filipesilva]

Just wanted to mention I hit this too. Same thing: Swagger was fine with it, but it didn't fail coercion.

I'm up for doing a PR. So what should be the right thing to do here? Only accept int keys? Accept kw and int in both?

[ikitommi]

For numbers, accepting just int-keys sense to me.