Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: radolan_test.cpp failing #3

Open
kmuehlbauer opened this issue May 12, 2016 · 4 comments
Open

BUG: radolan_test.cpp failing #3

kmuehlbauer opened this issue May 12, 2016 · 4 comments

Comments

@kmuehlbauer
Copy link
Contributor

When I run radolan_test, the test breaks with:

FAILED:geographical coordinates of anchor point don't match

When I change the indices here to (450,450), then I get the correct results. However, the test still breaks, because the latitude values differ 1.42109e-14.

So there are two issues:

  • indices, is 450, 450 correct?
  • precision in comparing doubles

This is blocking conda-forge/staged-recipes#591 from adding the test.

@kmuehlbauer
Copy link
Contributor Author

After some testing, this turns out to be a bug within the coordinate_system.cpp, IMHO.

@kmuehlbauer
Copy link
Contributor Author

@JuergenSimon Did you have time to look into this? Is this cruzial for using libradolan, or is this just minor?

@JuergenSimon
Copy link
Contributor

Hi, I had no time to look at any of this yet. I think it is a minor difference and wanted to replace the value test with a range test instead but never got round to it. Unfortunately I won't have any time in the foreseeable months for this project, sorry!

@kmuehlbauer
Copy link
Contributor Author

@JuergenSimon Didn't want to stalk you. It would be very helpful if you just have a look, when pinging. I promis, I'll not overuse it 😀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants