-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eks.amazonaws.com/role-arn
annotation
#46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: t4lz <[email protected]>
|
||
aws iam create-role --role-name mirrord-operator-role --assume-role-policy-document file://trust-relationship.json --description "Role for SQS splitting for mirrord-operator" | ||
|
||
aws iam attach-role-policy --role-name mirrord-operator-role --policy-arn=arn:aws:iam::$account_id:policy/mirrord-operator-role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran this I got
An error occurred (NoSuchEntity) when calling the AttachRolePolicy operation: Policy arn:aws:iam::<redacted_by_t4lz>:policy/mirrord-operator-role does not exist or is not attachable.
So for my testing I just attached mirrorrd-operator-role
to the preexisting AmazonSQSFullAccess
policy (with ARN arn:aws:iam::aws:policy/AmazonSQSFullAccess
). I don't know if that's a valid solution for our users as well, or if the limitation to a specific account id in our custom policy is important.
@Razz4780 @DmitryDodzin @t4lz do we need this? |
Don't think so, I've seen arn role both in |
Well we can slim up the doc section because it's mostly copy-paste from aws-docs but the |
I based #84 on this branch, so these commits are already merged (but I did change the README). |
Add
sa.roleArn
value that maps toeks.amazonaws.com/role-arn
annotation on service account.relevant for metalbear-co/mirrord#2293.